javascript - gnezdenje - konkretno na mojem primeru

var filterTool = {

	name: null,
	year: null,
	genre: null,
	rating: null,
	input: null,
	selected: null,
	reverse: false,

	init: function() {
		$('#filter').css('visibility', 'visible');

		this.name = $('#filter_name');
		this.year = $('#filter_year');
		this.genre = $('#filter_genre');
		this.rating = $('#filter_rating');
		this.input = $('#filter_input');
		this.count = $('#filter_count');

		this.name.click(this.filter);
		this.year.click(this.filter);
		this.genre.click(this.filter);
		this.rating.click(this.filter);
		this.input.keyup(this.filter);

		this.name.click();
	},

	filter: function(e){
		if(e.target != filterTool.input.get(0)){
			if(!filterTool.selected || filterTool.selected.get(0) != e.target){
				if(filterTool.selected) filterTool.selected.removeClass('disabled');
				
				if(e.target == filterTool.name.get(0)) filterTool.selected = filterTool.name;
				else if(e.target == filterTool.year.get(0)) filterTool.selected = filterTool.year;
				else if(e.target == filterTool.genre.get(0)) filterTool.selected = filterTool.genre;
				else if(e.target == filterTool.rating.get(0)) filterTool.selected = filterTool.rating;

				filterTool.selected.addClass('disabled');
			}else {

				filterTool.reverse = !filterTool.reverse && filterTool.selected && e.target == filterTool.selected.get(0);
			}
		} else if(e.keyCode != 13) return;

	var sortType = filterTool.selected == filterTool.genre?'genre:first':(filterTool.selected == filterTool.year?'year:first':'title:last');

//**** tukaj bi NEKAKO VKOMPONIRAL ŠE rating

	var sortType = filterTool.selected == filterTool.rating?'rating:first':(filterTool.selected == filterTool.year?'year:first':'title:last');

//**** 	
		 var fStr = filterTool.input.val();
		 var arr = !fStr?rawXML.find('movie,tvshow'):rawXML.find("movie > title:contains('" + fStr + "'),tvshow > title:contains('" + fStr + "')").parent();

		arr.sort(function(a, b){
					var at = $(a).find(sortType).text();
					var bt = $(b).find(sortType).text();

					if(sortType == 'year:first'){
						if($(a).get(0).tagName == 'tvshow') at = $(a).find('premiered:first').text().substr(0,4);
						else if($(b).get(0).tagName == 'tvshow') bt = $(b).find('premiered:first').text().substr(0,4);

						at = parseInt(at);
						bt = parseInt(bt);
					}
					
					if(at < bt) return filterTool.reverse?1:-1;
					if(at > bt) return filterTool.reverse?-1:1;
					return 0;
				});

		//
		movies = [];
		videoSmallInfo.hide();
		itemSel = null;
		$(itemCont).empty();

		arr.each(function(){ movies.push(new videoItem($(this))); });
		
		if(movies.length > 0) movies[0].select();

		filterTool.count.text(movies.length + ' flm.');

		window_RESIZE(null);
	}
}

ales85 je 11. dec 2015 ob 05:06 izjavil:

sortType lahko uporabiš kot polje in notri shraniš več vrednosti, nato pa preverjaš kateri filter se pojavi v tem polju.

geca je 11. dec 2015 ob 08:57 izjavil:

Spodnji špeh conditional statementov ...

var sortType = filterTool.selected == filterTool.genre?'genre:first':(filterTool.selected == filterTool.year?'year:first':'title:last');

... zapiši kot ...

 var sortType = 'title:last'; // Privzeto po naslovu.
 
 // Grdo. :( Bomo lepšali, če deluje. ;)
 if (filterTool.selected === filterTool.rating) {
 sortType = 'rating:first';
 } else if (filterTool.selected === filterTool.year) {
 sortType = 'year:first';
 } else if (filterTool.selected === filterTool.genre) {
 sortType = 'genre:first';
 }
 

... in javi, če špila.

Kvaliteta = K1 + " x " + K2 + " / " + K3; // Npr. 1980 x 1024 / h264
dvC.find('.sub:eq(11) span').text(Kvaliteta);

arr = [];

K1 = xDoc.find('width:not(:empty)').each(function(){ if(arr.indexOf($(this).text()) < 0) arr.push($(this).text()); });
K2 = xDoc.find('height:not(:empty)').each(function(){ if(arr.indexOf($(this).text()) < 0) arr.push($(this).text()); });
K3 = xDoc.find('codec:not(:empty)').each(function(){ if(arr.indexOf($(this).text()) < 0) arr.push($(this).text()); });

Kvaliteta = arr[0] + " x " + arr[1] + " / " + arr[2];
dvC.find('.sub:eq(11) span').text(Kvaliteta);

K4 = xDoc.find('codec:not(:empty)').each(function(){ if(arr.indexOf($(this).text()) < 0) arr.push($(this).text()); });
Kvaliteta = arr[0] + " x " + arr[1] + " / video: " + arr[2]  + " / audio: " + arr[3];